From 5f3a33f659b40b52875e142fc39449430e22e537 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@gnu.org>
Date: Fri, 6 Jun 2025 10:23:31 +0200
Subject: [PATCH] services: rsync: Remove Shepherd 0.9.0 compatibility shim.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/services/rsync.scm (rsync-shepherd-service): Remove
‘inetd-style?’.

Change-Id: Iab4a72ade621add1cf6e186c6c6a8be415829d11
---
 gnu/services/rsync.scm | 45 +++++++++++++++---------------------------
 1 file changed, 16 insertions(+), 29 deletions(-)

diff --git a/gnu/services/rsync.scm b/gnu/services/rsync.scm
index 4bbf2c4eff..6f658a4b65 100644
--- a/gnu/services/rsync.scm
+++ b/gnu/services/rsync.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017 Oleg Pykhalov <go.wigust@gmail.com>
-;;; Copyright © 2021, 2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2021, 2023, 2025 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2023 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -226,12 +226,6 @@ please use 'modules' instead~%")))
 
 (define (rsync-shepherd-service config)
   "Return a <shepherd-service> for rsync with CONFIG."
-
-  ;; XXX: Predicates copied from (gnu services ssh).
-  (define inetd-style?
-    #~(and (defined? 'make-inetd-constructor)
-           (not (string=? (@ (shepherd config) Version) "0.9.0"))))
-
   (define ipv6-support?
     #~(catch 'system-error
         (lambda ()
@@ -280,28 +274,21 @@ please use 'modules' instead~%")))
              (requirement '(user-processes))
              (documentation "Run rsync daemon.")
              (actions (list (shepherd-configuration-action config-file)))
-             (start #~(if #$inetd-style?
-                          (make-inetd-constructor
-                           #$rsync-command
-                           (cons (endpoint
-                                  (make-socket-address AF_INET INADDR_ANY
-                                                       #$port-number))
-                                 (if #$ipv6-support?
-                                     (list
-                                      (endpoint
-                                       (make-socket-address AF_INET6 IN6ADDR_ANY
-                                                            #$port-number)))
-                                     '()))
-                           #:service-name-stem "rsync"
-                           #:user #$user
-                           #:group #$group)
-                          (make-forkexec-constructor #$rsync-command
-                                                     #:pid-file #$pid-file
-                                                     #:user #$user
-                                                     #:group #$group)))
-             (stop #~(if #$inetd-style?
-                         (make-inetd-destructor)
-                         (make-kill-destructor))))))))
+             (start #~(make-inetd-constructor
+                       #$rsync-command
+                       (cons (endpoint
+                              (make-socket-address AF_INET INADDR_ANY
+                                                   #$port-number))
+                             (if #$ipv6-support?
+                                 (list
+                                  (endpoint
+                                   (make-socket-address AF_INET6 IN6ADDR_ANY
+                                                        #$port-number)))
+                                 '()))
+                       #:service-name-stem "rsync"
+                       #:user #$user
+                       #:group #$group))
+             (stop #~(make-inetd-destructor)))))))
 
 (define rsync-service-type
   (service-type