From 9a759d93e67ee96662ec4ebaf89c9892e7afeaa2 Mon Sep 17 00:00:00 2001 From: Vivien Kraus Date: Mon, 27 Apr 2026 15:22:56 +0200 Subject: [PATCH] gnu: orca: Prevent crash on startup. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/patches/orca-fix-gst-init-check-call.patch: New file. * gnu/local.mk (dist_patch_DATA): Reference it here. * gnu/packages/gnome.scm (orca): Use it here. [#:phases]: Adapt to upstream quote style change. [inputs]: Add python-dbus. Change-Id: I585d610901c7c3d488840c00f0a1d03942eebe01 Signed-off-by: Noé Lopez --- gnu/local.mk | 1 + gnu/packages/gnome.scm | 6 ++-- .../orca-fix-gst-init-check-call.patch | 28 +++++++++++++++++++ 3 files changed, 33 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/orca-fix-gst-init-check-call.patch diff --git a/gnu/local.mk b/gnu/local.mk index 4e37022ac2e..87a7793a478 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2070,6 +2070,7 @@ dist_patch_DATA = \ %D%/packages/patches/open-zwave-hidapi.patch \ %D%/packages/patches/opusfile-CVE-2022-47021.patch \ %D%/packages/patches/orbit2-fix-array-allocation-32bit.patch \ + %D%/packages/patches/orca-fix-gst-init-check-call.patch \ %D%/packages/patches/orpheus-cast-errors-and-includes.patch \ %D%/packages/patches/ots-no-include-missing-file.patch \ %D%/packages/patches/owncloud-disable-updatecheck.patch \ diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 8a75b156d94..a170f42755b 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -11575,7 +11575,8 @@ accessibility infrastructure.") name "-" version ".tar.xz")) (sha256 (base32 - "0sfs06f66dsibvnp87jshhs7n3f8shkn9x7j3ygpk8409za2n2xy")))) + "0sfs06f66dsibvnp87jshhs7n3f8shkn9x7j3ygpk8409za2n2xy")) + (patches (search-patches "orca-fix-gst-init-check-call.patch")))) (build-system meson-build-system) (arguments '(#:glib-or-gtk? #t @@ -11593,7 +11594,7 @@ accessibility infrastructure.") (pgrep (string-append (assoc-ref inputs "procps") "/bin/pgrep"))) (substitute* "src/orca/orca_modifier_manager.py" - (("'xkbcomp'") (format #f "'~a'" xkbcomp))) + (("\"xkbcomp\"") (format #f "'~a'" xkbcomp))) (substitute* "src/orca/debug.py" (("'pgrep %s'") (format #f "'~a %s'" pgrep))) @@ -11627,6 +11628,7 @@ accessibility infrastructure.") `(,liblouis "python") procps ; for pgrep python + python-dbus python-pygobject-3.50 python-pyatspi speech-dispatcher diff --git a/gnu/packages/patches/orca-fix-gst-init-check-call.patch b/gnu/packages/patches/orca-fix-gst-init-check-call.patch new file mode 100644 index 00000000000..d806570ce6f --- /dev/null +++ b/gnu/packages/patches/orca-fix-gst-init-check-call.patch @@ -0,0 +1,28 @@ +From 98300ecbb26fcacb0f7a722629fc50b4ec6bd1ab Mon Sep 17 00:00:00 2001 +Message-ID: <98300ecbb26fcacb0f7a722629fc50b4ec6bd1ab.1777294348.git.vivien@planete-kraus.eu> +From: Vivien Kraus +Date: Mon, 27 Apr 2026 14:51:07 +0200 +Subject: [PATCH] Fix invalid Gst.init_check call + +init_check accepts a list of program arguments. An empty list works. + +--- + src/orca/sound.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/orca/sound.py b/src/orca/sound.py +index d507a371d..b1129609f 100644 +--- a/src/orca/sound.py ++++ b/src/orca/sound.py +@@ -34,7 +34,7 @@ try: + except Exception: + _gstreamerAvailable = False + else: +- _gstreamerAvailable, args = Gst.init_check(None) ++ _gstreamerAvailable, args = Gst.init_check([]) + + from . import debug + from .sound_generator import Icon, Tone +-- +2.52.0 +