From a59f32a2c36c8fa54dde8faa8decb67db7e2e29e Mon Sep 17 00:00:00 2001
From: Cayetano Santos <csantosb@inventati.org>
Date: Fri, 25 Jul 2025 20:04:59 +0200
Subject: [PATCH] gnu: xyce-parallel: Improve style.

* gnu/packages/engineering.scm (xyce-parallel)[arguments]: Use
G-Expressions.
[inputs]: Modernize.
[native-inputs]: Modernize.

Change-Id: I627bf9063b5e3e29e97fb43b09e8c31d1404298a
Signed-off-by: Gabriel Wicki <gabriel@erlikon.ch>
---
 gnu/packages/engineering.scm | 42 +++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 73cd45a7fb..00cbdea33a 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2400,31 +2400,29 @@ parallel computing platforms.  It also supports serial execution.")
        (prepend openmpi)))))
 
 (define-public xyce-parallel
-  (package (inherit xyce-serial)
+  (package
+    (inherit xyce-serial)
     (name "xyce-parallel")
     (arguments
-     `(,@(substitute-keyword-arguments (package-arguments xyce-serial)
-           ((#:configure-flags flags)
-            `(list "CXXFLAGS=-O3"
-                   "CXX=mpiCC"
-                   "CC=mpicc"
-                   "F77=mpif77"
-                   "--enable-mpi"
-                   (string-append
-                           "CFLAGS="
-                           " -Wno-error=builtin-declaration-mismatch"
-                           " -Wno-error=implicit-function-declaration"
-                           " -Wno-error=implicit-int")
-                   (string-append
-                    "ARCHDIR="
-                    (assoc-ref %build-inputs "trilinos")))))))
-    (propagated-inputs
-     `(("mpi" ,openmpi)))
+     (substitute-keyword-arguments
+         (package-arguments xyce-serial)
+       ((#:configure-flags flags)
+        #~(list "CXXFLAGS=-O3"
+                "CXX=mpiCC"
+                "CC=mpicc"
+                "F77=mpif77"
+                "--enable-mpi"
+                (string-append
+                 "CFLAGS="
+                 " -Wno-error=builtin-declaration-mismatch"
+                 " -Wno-error=implicit-function-declaration"
+                 " -Wno-error=implicit-int")
+                (string-append "ARCHDIR=" #$trilinos-parallel-xyce)))))
+    (propagated-inputs (list openmpi))
     (inputs
-     `(("trilinos" ,trilinos-parallel-xyce)
-       ("zlib" ,zlib)
-       ,@(alist-delete "trilinos"
-                       (package-inputs xyce-serial))))))
+     (modify-inputs (package-inputs xyce-serial)
+       (append zlib)
+       (replace "trilinos-serial-xyce" trilinos-parallel-xyce)))))
 
 (define-public librepcb
   (package