1
0
mirror of https://git.savannah.gnu.org/git/guix.git synced 2026-05-26 11:01:48 +02:00

derivations: ‘derivation-build-plan’ returns builds in topological order.

That makes ‘derivation-build-plan’ directly usable in cases where one
wants to sequentially build derivations one by one, or to report builds
in the right order in the user interface.

* guix/derivations.scm (derivation-build-plan): Wrap ‘loop’ in
‘traverse’.  Perform a depth-first traversal.  Return the list of builds
in topological order.
* tests/derivations.scm ("derivation-build-plan, topological ordering"):
New test.

Change-Id: I7cd9083f42c4381b4213794a40dbb5b234df966d
This commit is contained in:
Ludovic Courtès
2024-10-22 15:01:48 +02:00
parent 9793403bc0
commit c62f8ab11f
2 changed files with 72 additions and 33 deletions
+29 -2
View File
@@ -1,5 +1,5 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2012-2023 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2012-2024 Ludovic Courtès <ludo@gnu.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -29,7 +29,8 @@
#:use-module (guix tests git)
#:use-module (guix tests http)
#:use-module ((guix packages) #:select (package-derivation base32))
#:use-module ((guix build utils) #:select (executable-file?))
#:use-module ((guix build utils)
#:select (executable-file? strip-store-file-name))
#:use-module ((guix hash) #:select (file-hash*))
#:use-module ((git oid) #:select (oid->string))
#:use-module ((git reference) #:select (reference-name->oid))
@@ -1157,6 +1158,32 @@
#:mode (build-mode check))
(list drv dep))))))
(test-equal "derivation-build-plan, topological ordering"
(make-list 5 '("0.drv" "1.drv" "2.drv" "3.drv" "4.drv"))
(with-store store
(define (test _)
(let* ((simple-derivation
(lambda (name . deps)
(build-expression->derivation
store name
`(begin ,(random-text) (mkdir %output))
#:inputs (map (lambda (n dep)
(list (number->string n) dep))
(iota (length deps))
deps))))
(drv0 (simple-derivation "0"))
(drv1 (simple-derivation "1" drv0))
(drv2 (simple-derivation "2" drv1))
(drv3 (simple-derivation "3" drv2 drv0))
(drv4 (simple-derivation "4" drv3 drv1)))
(map (compose strip-store-file-name derivation-file-name)
(derivation-build-plan store (list (derivation-input drv4))))))
;; This is probabilistic: if the traversal is buggy, it may or may not
;; produce the wrong ordering, depending on a variety of actors. Thus,
;; try multiple times.
(map test (iota 5))))
(test-assert "derivation-input-fold"
(let* ((builder (add-text-to-store %store "my-builder.sh"
"echo hello, world > \"$out\"\n"