tribes/guix
1
0
Fork 1
mirror of https://git.savannah.gnu.org/git/guix.git synced 2026-05-28 12:01:49 +02:00
Code Activity

lint: formatting: Gracefully handle relative file names.

Browse Source 
Fixes <https://bugs.gnu.org/42543>.
Reported by Jack Hill <jackhill@jackhill.us>.

* guix/lint.scm (check-formatting): Always return a list (previously we
would return #f when 'search-path' returns #f).  Check whether
LOCATION's file is a relative file name.  Return a warning if not.
* tests/guix-lint.sh: Add test.
This commit is contained in:
Ludovic Courtès
2020-08-23 22:48:19 +02:00
parent 68193624d1
commit d10474c38d
2 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/guix-lint.sh
+11 -2
View File
@@ -22,8 +22,11 @@
guix lint --version
module_dir="t-guix-lint-$$"
mkdir "$module_dir"
# Choose a module directory not below any %LOAD-PATH component. This is
# necessary when testing '-L' with a relative file name.
module_dir="$(mktemp -d)"
mkdir -p "$module_dir"
trap "rm -rf $module_dir" EXIT
@@ -87,3 +90,9 @@ then false; else true; fi
# Make sure specifying multiple packages works.
guix lint -L $module_dir -c inputs-should-be-native dummy dummy@42 dummy
# Test '-L' with a relative file name. 'guix lint' will see "t-xyz/foo.scm"
# (instead of "foo.scm") and will thus fail to find it in %LOAD-PATH. Check
# that it does find it anyway. See <https://bugs.gnu.org/42543>.
(cd "$module_dir"/.. ; guix lint -c formatting -L "$(basename "$module_dir")" dummy@42) 2>&1 > "$module_dir/out"
test -z "$(cat "$module_dir/out")"